Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: nativebyteorder is not safe to use #1050

Merged
merged 4 commits into from
May 29, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 29, 2023

Solution:

  • check native byte order in init, panic if native byte order is not little endian.
  • build binary with nativebyteorder by default, big endian machine need to build it's own binary without the nativebyteorder tag.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- check native byte order in init, panic if native byte order is not little endian.
- build binary with nativebyteorder by default, big endian machine need to build it's own binary without the nativebyteorder tag.
@yihuang yihuang requested a review from a team as a code owner May 29, 2023 07:16
@yihuang yihuang requested review from mmsqe and devashishdxt and removed request for a team May 29, 2023 07:16
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #1050 (7c6408b) into main (03fc136) will increase coverage by 23.49%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1050       +/-   ##
===========================================
+ Coverage   22.76%   46.26%   +23.49%     
===========================================
  Files          50       82       +32     
  Lines        3026     7124     +4098     
===========================================
+ Hits          689     3296     +2607     
- Misses       2272     3476     +1204     
- Partials       65      352      +287     

see 49 files with indirect coverage changes

default.nix Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants