-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: memiavl minQueryState logic is unnesserary #1064
Merged
yihuang
merged 6 commits into
crypto-org-chain:main
from
yihuang:simply-snapshot-rewrite
Jun 15, 2023
Merged
Problem: memiavl minQueryState logic is unnesserary #1064
yihuang
merged 6 commits into
crypto-org-chain:main
from
yihuang:simply-snapshot-rewrite
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: - simplify the logic, make snapshot-keep-recent defaults to 1, which is enough for ibc relayers to work.
yihuang
commented
Jun 15, 2023
Signed-off-by: yihuang <huang@crypto.com>
Codecov Report
@@ Coverage Diff @@
## main #1064 +/- ##
==========================================
- Coverage 46.72% 46.56% -0.17%
==========================================
Files 82 82
Lines 7124 7095 -29
==========================================
- Hits 3329 3304 -25
+ Misses 3442 3440 -2
+ Partials 353 351 -2
|
yihuang
requested review from
mmsqe and
calvinaco
and removed request for
a team
June 15, 2023 08:37
mmsqe
approved these changes
Jun 15, 2023
yihuang
force-pushed
the
simply-snapshot-rewrite
branch
from
June 15, 2023 09:34
954006e
to
9d49275
Compare
mmsqe
reviewed
Jun 15, 2023
Co-authored-by: mmsqe <mavis@crypto.com> Signed-off-by: yihuang <huang@crypto.com>
13 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
fixed chain-main integration test: crypto-org-chain/chain-main#989
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)