Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: memiavl setup code is not reusable #1082

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jun 26, 2023

Solution:

  • put into store package

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- put into store package
@yihuang yihuang requested a review from a team as a code owner June 26, 2023 02:49
@yihuang yihuang requested review from JayT106 and thomas-nguy and removed request for a team June 26, 2023 02:49
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
@yihuang yihuang requested a review from mmsqe June 26, 2023 02:50
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1082 (b0d4202) into main (f83c74b) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
+ Coverage   46.13%   46.20%   +0.06%     
==========================================
  Files          82       80       -2     
  Lines        7203     7173      -30     
==========================================
- Hits         3323     3314       -9     
+ Misses       3522     3502      -20     
+ Partials      358      357       -1     

see 2 files with indirect coverage changes

@yihuang yihuang enabled auto-merge June 26, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants