Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: zero-copy is unsafe to use with current sdk behavior #1092

Merged
merged 6 commits into from
Jul 5, 2023
Merged

Problem: zero-copy is unsafe to use with current sdk behavior #1092

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a5b357
Problem: zero-copy is unsafe to use with current sdk behavior
yihuang Jul 4, 2023
e690f76
Update CHANGELOG.md
yihuang Jul 4, 2023
4e5b367
disable address cache
yihuang Jul 5, 2023
2b1fd08
zero-copy is safe to use again
yihuang Jul 5, 2023
77e9f43
Merge branch 'main' into zero-copy
yihuang Jul 5, 2023
6249278
merged
yihuang Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
- [#1064](https://github.com/crypto-org-chain/cronos/pull/1064) Simplify memiavl snapshot switching.
- [#1067](https://github.com/crypto-org-chain/cronos/pull/1067) memiavl: only export state-sync snapshots on an exist snapshot
- [#1082](https://github.com/crypto-org-chain/cronos/pull/1082) Make memiavl setup code reusable.
- [#1092](https://github.com/crypto-org-chain/cronos/pull/1092) memiavl disable zero-copy by default.

*April 13, 2023*

Expand Down
1 change: 0 additions & 1 deletion integration_tests/configs/default.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
'app-config': {
memiavl: {
enable: true,
'zero-copy': true,
'snapshot-interval': 5,
},
store: {
Expand Down
2 changes: 1 addition & 1 deletion store/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ type MemIAVLConfig struct {
Enable bool `mapstructure:"enable"`
// ZeroCopy defines if the memiavl should return slices pointing to mmap-ed buffers directly (zero-copy),
// the zero-copied slices must not be retained beyond current block's execution.
// zero-copy is unsafe to use with current sdk's address cache.
ZeroCopy bool `mapstructure:"zero-copy"`
// AsyncCommitBuffer defines the size of asynchronous commit queue, this greatly improve block catching-up
// performance, -1 means synchronous commit.
Expand All @@ -26,7 +27,6 @@ func DefaultMemIAVLConfig() MemIAVLConfig {
return MemIAVLConfig{
CacheSize: DefaultCacheSize,
SnapshotInterval: memiavl.DefaultSnapshotInterval,
ZeroCopy: true,
SnapshotKeepRecent: 1,
}
}
1 change: 1 addition & 0 deletions store/config/toml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ enable = {{ .MemIAVL.Enable }}

# ZeroCopy defines if the memiavl should return slices pointing to mmap-ed buffers directly (zero-copy),
# the zero-copied slices must not be retained beyond current block's execution.
# zero-copy is unsafe to use with current sdk's address cache.
zero-copy = {{ .MemIAVL.ZeroCopy }}

# AsyncCommitBuffer defines the size of asynchronous commit queue, this greatly improve block catching-up
Expand Down