-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: upgrade with versiondb and memiavl is not tested #1205
Conversation
Solution: - enable memiavl and versiondb in upgrade test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need use newer binary in upgrade-test-package.nix right?
yes, changed to |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1205 +/- ##
=======================================
Coverage 36.95% 36.95%
=======================================
Files 115 115
Lines 10235 10235
=======================================
Hits 3782 3782
Misses 6080 6080
Partials 373 373
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we update all submodules 1st, the lint error seems also relate to it
I see, thanks, lint error because of build failure with wrong librocksdb. |
Signed-off-by: yihuang <huang@crypto.com>
03edb77
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)