-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: ethermint is not updated #1215
Conversation
Signed-off-by: mmsqe <mavis@crypto.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
===========================================
+ Coverage 16.70% 36.95% +20.25%
===========================================
Files 79 115 +36
Lines 5766 10235 +4469
===========================================
+ Hits 963 3782 +2819
- Misses 4725 6080 +1355
- Partials 78 373 +295
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
is it going to be part of the next release or bug fix for the upcoming release?
maybe just as a bug fix, but not sure if we need back port to v1.0.x @yihuang |
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)