Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: memory leak in versiondb #1491

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Problem: memory leak in versiondb #1491

merged 1 commit into from
Jun 28, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jun 28, 2024 •
edited by coderabbitai bot
Loading

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Bug Fixes
    • Improved resource management by ensuring proper cleanup for version checks, preventing potential memory issues.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 28, 2024 •
edited
Loading

Walkthrough

This update introduces a crucial change to the HasAtVersion function in the Store struct within the Cronos project. Specifically, a defer slice.Free() statement is added to ensure proper resource cleanup by deallocating slice data before the function returns. This enhancement aims to improve memory management and prevent potential memory leaks.

Changes

File Change Summary
CHANGELOG.md Updated CHANGELOG.md to reflect the addition of defer slice.Free() in the HasAtVersion function.
.../versiondb/tsrocksdb/store.go Added defer slice.Free() in the HasAtVersion function to ensure proper resource cleanup.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Store
    participant RocksDB
    Client->>Store: Call HasAtVersion
    Store->>RocksDB: Check for key at version
    note right of Store: defer slice.Free() 
    RocksDB-->>Store: Return result
    Store-->>Client: Return result
Loading

Poem

In code, we weave a tidy tale,
Where slices now are freed without fail,
No memory leaks, no lingering thread,
In Cronos' land, our care is spread.
So let us cheer this prudent deed,
For cleaner code, we've all agreed!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Jun 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.86%. Comparing base (6537ed3) to head (8bce49f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1491   +/-   ##
=======================================
  Coverage   35.85%   35.86%           
=======================================
  Files         136      136           
  Lines        9806     9807    +1     
=======================================
+ Hits         3516     3517    +1     
  Misses       5894     5894           
  Partials      396      396
Files Coverage Δ
versiondb/tsrocksdb/store.go 54.36% <100.00%> (+0.30%) ⬆️

@mmsqe mmsqe marked this pull request as ready for review June 28, 2024 02:37
@mmsqe mmsqe requested a review from a team as a code owner June 28, 2024 02:37
@mmsqe mmsqe requested review from yihuang and JayT106 and removed request for a team June 28, 2024 02:37
@yihuang yihuang changed the title Problem: no free slice data in HasAtVersion Problem: memory leak in versiondb Jun 28, 2024
@mmsqe mmsqe enabled auto-merge June 28, 2024 02:47
coderabbitai[bot]
coderabbitai bot reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6537ed3 and 8bce49f.

Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • versiondb/tsrocksdb/store.go (1 hunks)
Additional context used
LanguageTool
CHANGELOG.md

[grammar] ~21-~21: The conjunction “when” requires the past participle “registered”. Or did you mean “you register”?
Context: ...ronos/pull/1421) Validate e2ee key when register. * (store) [#1448](https://github.com/c...

(IF_VB_PCT)

[misspelling] ~131-~131: Did you mean “or”? ‘Of’ refers to parts of a whole, while ‘or’ refers to alternatives.
Context: ...onos/pull/1216) Update ethermint to fix of avoid redundant parse chainID from gens...

(CONFUSION_OF_OR)

[style] ~172-~172: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...n processing and double spend check. - [cronos#742](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~173-~173: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha2. - [cronos#750](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~174-~174: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha3. - [cronos#769](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~175-~175: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...cope of the contract that manage it. - [cronos#775](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~176-~176: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...775) Support turnbridge transaction. - [cronos#781](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~177-~177: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../cronos/pull/781) Add prune command. - [cronos#830](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~180-~180: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...upgrade handler for v2.0.0-testnet3. - [cronos#795](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~181-~181: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../795) Support permissions in cronos. - [cronos#997](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~182-~182: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ontract for cronos originated crc20. - [cronos#1005](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~183-~183: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...o-ibc event in case of source token. - [cronos#1069](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~184-~184: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...o v1.10.26 and ibc-go to v6.2.0. - [cronos#1147](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~188-~188: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...adjusted correctly in ibc-go v7.2.0. - [cronos#1163](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~189-~189: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ateful precompiled contract for ica. - [cronos#837](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~190-~190: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...teful precompiled contract for bank. - [cronos#1184](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~191-~191: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ull/1184) Update ibc-go to v7.3.1. - [cronos#1186](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~192-~192: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... max block gas limit in new version. - [cronos#1187](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~193-~193: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...1187) Disable gravity module in app. - [cronos#1185](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~194-~194: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nos/pull/1185) Support ibc callback. - [cronos#1196](https://github.com/crypto-org-cha...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[grammar] ~213-~213: It seems that “to” is missing before the verb.
Context: .../cronos/pull/1150) Fix memiavl's unsafe retain of the root hashes. ### Features - [#...

(MISSING_TO_BETWEEN_BE_AND_VB)

[misspelling] ~217-~217: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’?
Context: .../pull/1042) call Close method on app to cleanup resource on graceful shutdown ([ethermi...

(CLEAN_UP)

[grammar] ~333-~333: After ‘it’, use the third-person verb form “fixes”.
Context: ...790) Update cosmos-sdk to v0.46.7, it fix a migration issue which affects pending...

(IT_VBZ)

[style] ~400-~400: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...file state streamer (backport #702). - [cronos#730](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~422-~422: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...elSendToChain support from evm call. - [cronos#600](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~423-~423: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...plement bidirectional token mapping. - [cronos#611](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~424-~424: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...owledgement error in ibc middleware. - [cronos#627](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~439-~439: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...leware, use ibc-go upstream version. - [cronos#550](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~440-~440: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...basic json-rpc apis on pruned nodes. - [cronos#549](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~441-~441: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom tx indexer feature of ethermint. - [cronos#673](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~459-~459: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ed in json-rpc apis (backport #502). - [cronos#526](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~460-~460: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... Fix tendermint duplicated tx issue. - [cronos#584](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~461-~461: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...shes returned in some JSON-RPC apis. - [cronos#587](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~462-~462: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx patch cmd recompute eth tx hash. - [cronos#595](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~468-~468: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nd to patch txs post v0.7.0 upgrade. - [cronos#522](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~469-~469: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... the tendermint tx duplicated issue. - [cronos#585](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~483-~483: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ase fee related logic in the code. - [ethermint#817](https://github.com/tharsis/ethermi...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~484-~484: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ogic related to effectiveGasPrice. - [ethermint#822](https://github.com/tharsis/ethermi...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~487-~487: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx when block gas limit exceeded. - [cosmos-sdk#10725](https://github.com/cosmos/cosmos...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~495-~495: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e url query parameter in swagger-ui. - [cronos#328](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~496-~496: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...query result when --trace enabled. - [cronos#441](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~503-~503: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...ll/329) Fix panic of eth_call on blocks prior to upgrade. - [cronos#340](https://github....

(EN_WORDINESS_PREMIUM_PRIOR_TO)

[style] ~504-~504: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...eth_call on blocks prior to upgrade. - [cronos#340](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~505-~505: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...t, b) fix data races traceContext. - [cronos#370](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~506-~506: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...g, add websockets integration tests. - [cronos#378](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[style] ~507-~507: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... add returnValue message on tracing. - [cronos#446](https://github.com/crypto-org-chai...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

[grammar] ~627-~627: After ‘it’, use the third-person verb form “upgrades”.
Context: ...org Chain. In addition to that, it also upgrade ethermint to its latest version (v0.5.0...

(IT_VBZ)

Markdownlint
CHANGELOG.md

55-55: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

67-67: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

75-75: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

83-83: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

91-91: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

92-92: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

93-93: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

97-97: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

105-105: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

106-106: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

107-107: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

108-108: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

109-109: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

110-110: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

114-114: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

115-115: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

121-121: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

122-122: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

123-123: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

124-124: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

125-125: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

129-129: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

130-130: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

131-131: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

132-132: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

133-133: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

134-134: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

138-138: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

139-139: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

140-140: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

141-141: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

142-142: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

143-143: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

147-147: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

148-148: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

149-149: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

157-157: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

158-158: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

162-162: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

170-170: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

171-171: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

172-172: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

173-173: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

174-174: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

175-175: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

176-176: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

177-177: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

178-178: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

179-179: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

180-180: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

181-181: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

182-182: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

183-183: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

184-184: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

185-185: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

186-186: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

187-187: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

188-188: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

189-189: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

190-190: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

191-191: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

192-192: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

193-193: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

194-194: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

198-198: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

199-199: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

200-200: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

201-201: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

202-202: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

203-203: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

204-204: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

205-205: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

206-206: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

207-207: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

208-208: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

209-209: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

210-210: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

211-211: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

212-212: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

213-213: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

217-217: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

218-218: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

219-219: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

220-220: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

221-221: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

222-222: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

223-223: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

224-224: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

228-228: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

229-229: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

230-230: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

231-231: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

232-232: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

233-233: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

234-234: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

235-235: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

236-236: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

237-237: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

238-238: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

239-239: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

240-240: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

241-241: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

242-242: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

243-243: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

244-244: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

245-245: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

246-246: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

247-247: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

248-248: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

249-249: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

250-250: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

251-251: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

252-252: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

260-260: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

261-261: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

262-262: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

266-266: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

267-267: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

268-268: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

269-269: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

270-270: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

271-271: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

272-272: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

280-280: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

288-288: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

292-292: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

293-293: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

294-294: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

302-302: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

306-306: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

307-307: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

308-308: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

316-316: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

324-324: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

332-332: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

333-333: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

342-342: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

350-350: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

358-358: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

366-366: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

367-367: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

368-368: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

369-369: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

377-377: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

385-385: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

386-386: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

394-394: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

398-398: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

399-399: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

400-400: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

408-408: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

420-420: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

421-421: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

422-422: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

423-423: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

424-424: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

425-425: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

426-426: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

430-430: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

431-431: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

432-432: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

436-436: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

437-437: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

438-438: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

439-439: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

440-440: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

441-441: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

449-449: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

457-457: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

458-458: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

459-459: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

460-460: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

461-461: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

462-462: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

466-466: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

467-467: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

468-468: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

469-469: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

477-477: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

478-478: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

479-479: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

480-480: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

481-481: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

482-482: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

483-483: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

484-484: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

485-485: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

486-486: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

487-487: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

488-488: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

492-492: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

493-493: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

494-494: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

495-495: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

496-496: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

500-500: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

501-501: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

502-502: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

503-503: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

504-504: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

505-505: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

506-506: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

507-507: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

515-515: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

516-516: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

524-524: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

532-532: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

533-533: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

534-534: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

538-538: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

539-539: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

547-547: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

548-548: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

549-549: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

550-550: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

551-551: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

559-559: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

563-563: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

564-564: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

565-565: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

566-566: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

576-576: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

580-580: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

581-581: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

582-582: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

583-583: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

587-587: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

588-588: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

599-599: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

600-600: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

601-601: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

602-602: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

603-603: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

607-607: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

608-608: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

609-609: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

619-619: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

620-620: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

631-631: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

635-635: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

636-636: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

637-637: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

638-638: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

639-639: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

640-640: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

642-642: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

643-643: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

651-651: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

655-655: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

659-659: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

669-669: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

670-670: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

671-671: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

672-672: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

678-678: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

679-679: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

683-683: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

41-41: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

49-49: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

61-61: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

69-69: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

77-77: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

85-85: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

99-99: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

117-117: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

151-151: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

164-164: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

254-254: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

274-274: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

282-282: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

296-296: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

310-310: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

318-318: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

326-326: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

336-336: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

344-344: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

352-352: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

360-360: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

371-371: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

379-379: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

388-388: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

402-402: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

410-410: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

414-414: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

443-443: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

451-451: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

471-471: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

509-509: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

518-518: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

526-526: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

541-541: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

553-553: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

568-568: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

590-590: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

611-611: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

622-622: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

645-645: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

661-661: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

Additional comments not posted (2)
versiondb/tsrocksdb/store.go (1)

111-111: Ensure proper initialization before deferring resource release.

The addition of defer slice.Free() is a good practice to prevent memory leaks. However, ensure that slice is always initialized before this statement. If GetAtVersionSlice fails and returns a nil or uninitialized slice, this could lead to a runtime panic.

Verification successful

Initialization of slice is ensured before defer statement.

The slice variable is properly initialized by the GetAtVersionSlice function. If an error occurs, the function exits early, ensuring that defer slice.Free() is only called when slice is valid.

  • versiondb/tsrocksdb/store.go:
    • Line 107: slice, err := s.GetAtVersionSlice(storeKey, key, version)
    • Line 108-110: Early return on error ensures defer slice.Free() is safe.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that `slice` is always initialized before the defer statement is reached.

# Test: Search for any conditions that might cause `slice` to be nil or uninitialized when defer is called.
rg --type go $'GetAtVersionSlice' versiondb/tsrocksdb/store.go

Length of output: 284

Script:

#!/bin/bash
# Description: Retrieve the full implementation of the `HasAtVersion` function to verify the initialization of `slice`.

# Search for the implementation of the `HasAtVersion` function in the store.go file.
ast-grep --lang go --pattern 'func (s Store) HasAtVersion($_, $_, $_) ($_, $_) {
  $$$
}' versiondb/tsrocksdb/store.go

Length of output: 622

CHANGELOG.md (1)

29-29: Entry for PR #1491 is clear and concise.

This update is crucial for improving memory management in the HasAtVersion function by ensuring that slice data is properly freed. Good job on documenting this change clearly.

@mmsqe mmsqe added this pull request to the merge queue Jun 28, 2024
Merged via the queue into crypto-org-chain:main with commit 47fb783 Jun 28, 2024
45 checks passed
mmsqe added a commit that referenced this pull request Jun 28, 2024
@mmsqe
Problem: memory leak in versiondb (backport: #1491) (#1493)
af0bd9c 
* Problem: no free slice data in HasAtVersion

* run test_tx_inclusion

* less upgrade test
@coderabbitai coderabbitai bot mentioned this pull request Jul 2, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@yihuang yihuang yihuang approved these changes

@JayT106 JayT106 Awaiting requested review from JayT106 JayT106 is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
backport/v1.1.x backport/v1.2.x backport/v1.3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @yihuang