Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: archive node takes a long time to startup #667

Merged
merged 11 commits into from
Aug 25, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Aug 23, 2022

Closes: #666
Solution:

  • update dependency minor versions
  • update to golang 1.18 because some dependencies require that.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- update dependency minor versions
@yihuang yihuang requested a review from a team as a code owner August 23, 2022 10:08
@yihuang yihuang requested review from JayT106 and devashishdxt and removed request for a team August 23, 2022 10:08
CHANGELOG.md Outdated Show resolved Hide resolved
flake.lock Show resolved Hide resolved
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

it is not a breaking change right? Is there a documentation explaining what the optimization do? :)

@yihuang
Copy link
Collaborator Author

yihuang commented Aug 24, 2022

it is not a breaking change right?

It should be not breaking since its patch version number bumps, but we'll be cautious nonetheless to gradually try on some full nodes first, and there's no need to use it on validator nodes at all, since validators use pruning and don't suffer from slow startup too much.

Is there a documentation explaining what the optimization do? :)

the pr: cosmos/iavl#468
the spec: https://hackmd.io/cMctM2NsRlCIojnW3-mo5Q

nix/scripts.nix Show resolved Hide resolved
@yihuang yihuang changed the title Problem: iavl 0.19 optimization is not used Problem: archive node takes a long time to startup Aug 25, 2022
@yihuang yihuang enabled auto-merge (squash) August 25, 2022 07:04
@yihuang yihuang merged commit 66eafa6 into crypto-org-chain:release/v0.8.x Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants