Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: v1.0.x changes are not merged into main #816

Merged
merged 37 commits into from
Jan 26, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jan 19, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

yihuang and others added 28 commits September 9, 2022 08:25
…rg-chain#696)

* Problem: json-rpc apis fail for legacy blocks

Solution:
- keep the query handler in cosmos-sdk backward-compatible
- add integration test to check

* update sdk to upstream

* ibc-go to rc2
…rypto-org-chain#703) (crypto-org-chain#705)

* Problem: file changes detection in workflow is problematic

Solution:
- fix wildcards according the plugin's doc
- reformat python

* fix py-lint
…rypto-org-chain#713) (crypto-org-chain#719)

* Problem: after v0.9.0 upgrade eth_call failed on old blocks

Solution:
- make grpc query compatible with old format

* debug

* fix eth_call

* fix gravity upgrade test

* update ethermint to main branch

* update sdk
…n#702) (crypto-org-chain#721)

Solution:
- integration the basic file streamer

* add integration test

* changelog

* fix build

* fix lint

* fix deliver tx event in cosmos-sdk

* fix integration test

* Update integration_tests/test_streamer.py

Signed-off-by: yihuang <huang@crypto.com>

* update ethermint and fix build

* add a small cli utility into test_streamer.py

* fix integration test

* update sdk to upstream

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>
…org-chain#714) (crypto-org-chain#720)

* Problem: new iavl indexes migration is slow and not optional

Closes: crypto-org-chain#712
Solution:
- Integrate the option introduced in cosmos-sdk

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>
) (crypto-org-chain#730)

* Problem: recent dependencies are not used (backport crypto-org-chain#729)

Solution:
- update cosmos-sdk to 0.46.2, ibc-go to v5.0.0, ethermint to recent main branch

Update highlights:
- new flag to disable fast node migration
- fix streaming listeners bug
- fix grpc server panic
- fix index-eth-tx error on empty db

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>
…ted (crypto-org-chain#748)

* Problem: chain state is inconsistent if upgrade migration is interrupted

Solution:
- update cosmos-sdk with the fix

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* gomod2nix

* skip streamer test

Signed-off-by: yihuang <huang@crypto.com>
…ain#752)

* Problem: recent fixes in dependencies are not included

Solution:
- update cosmos-sdk and iavl

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* fix build

Signed-off-by: yihuang <huang@crypto.com>
)

* Problem: recent fixes in dependencies are not used

Solution:
- cosmos-sdk -> v0.46.4
- ethermint -> main
- ibc-go -> v5.0.1
- add dragonberry ics20 replacement

* maintain ethermint fork
Solution:
- revert the changes in ethermint
… query (crypto-org-chain#761)

* Problem: evm execute result is non-deterministic with concurrent grpc query

Solution:
- update dependencies to include the fix

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update go.mod

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>
…chain#762)

* Problem: extra_eips is not cleared on production network

Closes: crypto-org-chain#755
Solution:
- add 1.0.0 upgrade plan to clear it

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update integration_tests/test_upgrade.py

Signed-off-by: yihuang <huang@crypto.com>

* fix integration test

Signed-off-by: yihuang <huang@crypto.com>
…crypto-org-chain#763)

* Problem: no error log when iavl set failure trigger app hash mismatch

Solution:
- log the error in cosmos-sdk

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* PR merged

Signed-off-by: yihuang <huang@crypto.com>
…rypto-org-chain#764)

* Problem: different result from eth_getProof comparing with Ethereum

Solution:
- cherry-pick solution from ethermint, thanks @mmsqe

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>
* Problem: fixes in ibc-go v5.1 are not included

Solution:
- make a breaking change to upgrade to ibc-go `v5.1.0`.
- will do v1.0.0 upgrade on both testnet and mainnet.

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* fix lint

* include cache fix in tendermint

* update sdk

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* make different plan name v1.0.0-testnet3 for testnet3

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
…ain#772)

* Problem: formal v0.46.5 cosmos-sdk release is not used

Solution:
- update dependency, should be non-breaking for cronos

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* update to v0.46.6

Signed-off-by: yihuang <huang@crypto.com>
* Problem: cosmos-sdk `v0.46.7` is not used

Solution:
- update dependency
- `v0.46.7` fix a gov migration issue which affect query votes of old proposals.

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* use sdk streamers config

* fix streamer test

* fix file streamer integration test

* changelog

Signed-off-by: yihuang <huang@crypto.com>
* Problem: discontinued ibc-go version

Solution:
- update ibc-go to v5.2.0.
- do another coordinated upgrade on testnet3.

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* Update app/upgrades.go

Signed-off-by: yihuang <huang@crypto.com>

Signed-off-by: yihuang <huang@crypto.com>
…chain#813)

* Problem: production rocksdb configuration is not optimal

Solution:
- update related dependencies to allow customize rocksdb options.
- especially using rocksdb v7.
- tune rocksdb options.

* Update Makefile

Signed-off-by: yihuang <huang@crypto.com>

* remove rocksdb from niv

* rocksdb options

* update flake

* fix build

* create_if_missing

* OptimizeLevelStyleCompaction and IncreaseParallelism

* remove SetLevelCompactionDynamicLevelBytes and add BlockCache

* fix integration test

* comments

Signed-off-by: yihuang <huang@crypto.com>
* Problem: prometheus metrics is lost

Solution:
- setup correctly in ethermint

* changelog
@yihuang yihuang requested a review from a team as a code owner January 19, 2023 07:04
@yihuang yihuang removed the request for review from a team January 19, 2023 07:04
@yihuang yihuang requested review from mmsqe, calvinaco, thomas-nguy and a team January 19, 2023 07:04
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #816 (26ed55d) into main (79ebec3) will decrease coverage by 0.37%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
- Coverage   34.26%   33.89%   -0.37%     
==========================================
  Files          30       30              
  Lines        1582     1599      +17     
==========================================
  Hits          542      542              
- Misses        983     1000      +17     
  Partials       57       57              
Impacted Files Coverage Δ
app/upgrades.go 0.00% <0.00%> (ø)

CHANGELOG.md Outdated Show resolved Hide resolved
@tomtau
Copy link
Contributor

tomtau commented Jan 20, 2023

I guess for the next time, it'll be better to first patch on main and then backport to release branches: https://trunkbaseddevelopment.com/branch-for-release/ ?

@yihuang
Copy link
Collaborator Author

yihuang commented Jan 20, 2023

I guess for the next time, it'll be better to first patch on main and then backport to release branches: https://trunkbaseddevelopment.com/branch-for-release/ ?

For many changes, they need to be tested on testnet/mainnet first, but main branch is consensus breaking, thus current workflow.

@thomas-nguy
Copy link
Collaborator

thomas-nguy commented Jan 23, 2023

I guess some changes such as dependencies upgrades and bugfix could be done & tested on main first and then cherrypicked to release branches

for patches specific to release branch, some may not even need to be rebased on main

yihuang and others added 2 commits January 24, 2023 08:33
Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Signed-off-by: yihuang <huang@crypto.com>
@yihuang yihuang enabled auto-merge (squash) January 26, 2023 10:51
@yihuang yihuang merged commit c6dd8f9 into crypto-org-chain:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants