Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes for windows #2443

Merged
merged 4 commits into from
May 22, 2024
Merged

Build fixes for windows #2443

merged 4 commits into from
May 22, 2024

Conversation

k9ert
Copy link
Collaborator

@k9ert k9ert commented May 21, 2024

  • Babel and tzone had a strange bug which is due to parsing a wrong symlink in ubuntu which broke the linux-build. Therefore the change in .gitlab-ci.yml
  • test_requirements.txt does no longer exist. It's now located in the test-section of pyproject.yml
  • upgraded babel as a side-effect
  • aioitertools==0.11.0 has been forgotten at the latest jade-PR
  • The release-helper.py does no longer need the set_setup_py_version command and the install_wheel command was not usable in order to test the build locally. The new way of figuring out which version we're on is done fully automatically by setuptools_scm. It creates versionstrings via python3 -m setuptools_scm like 2.0.4rc9.dev0+g72b1b9a9.d20240522. Installing that needs something different that a fixed naming schema

The failed build is only the "tag_specterext_dummy_repo" job which doesn't work in my gitlab fork which i used to test the release process. Iinstead of git tag v2.0.4-pre8 && git push upstream v2.0.4-pre8 i used git tag v2.0.4-pre8 && git push origin v2.0.4-pre8. This will trigger the sync to my personal gitlab fork which will in turn trigger the gitlab release to my github-fork: https://github.com/k9ert/specter-desktop/releases/tag/v2.0.4-pre8

Copy link

netlify bot commented May 21, 2024

Deploy Preview for specter-desktop-docs canceled.

Name Link
🔨 Latest commit 72b1b9a
🔍 Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/664ccad5f3034b00084510bc

@k9ert k9ert marked this pull request as ready for review May 22, 2024 08:19
@k9ert k9ert requested a review from moneymanolis May 22, 2024 08:19
@k9ert k9ert merged commit d58232c into cryptoadvance:master May 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants