Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stream with readable-stream #22

Merged
merged 2 commits into from Aug 20, 2021
Merged

Replace stream with readable-stream #22

merged 2 commits into from Aug 20, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 13, 2021

#21

@ghost ghost mentioned this pull request Jul 13, 2021
@samuveth
Copy link

Very much needed for Vite!

@dievardump
Copy link

Could we have this merged so people not using webpack can use the library?

@fanatid
Copy link
Member

fanatid commented Aug 17, 2021

@byterose thank you for PR, two questions:

  1. readable-stream should be added to package.json
  2. Is it possible to solve webpack issue with resolve.fallback? Transform not found? #21 (comment)

@sirius651
Copy link

Is it possible to solve webpack issue with resolve.fallback? 

I tried to adding fallback, but it's not work. maybe above PR can work

@ghost
Copy link
Author

ghost commented Aug 19, 2021

@byterose thank you for PR, two questions:

  1. readable-stream should be added to package.json
  2. Is it possible to solve webpack issue with resolve.fallback? Transform not found? #21 (comment)
  1. I just pushed a commit to add readable-stream to package.json 🙂
  2. I tried to do this before I created this pr, but it didn't seem to work

@fanatid fanatid linked an issue Aug 20, 2021 that may be closed by this pull request
@fanatid fanatid merged commit 742b148 into cryptocoinjs:master Aug 20, 2021
@fanatid
Copy link
Member

fanatid commented Aug 20, 2021

Thanks! Published as 3.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transform not found?
4 participants