Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdbook deployment integration #215

Merged
merged 9 commits into from
Feb 16, 2023
Merged

mdbook deployment integration #215

merged 9 commits into from
Feb 16, 2023

Conversation

damilolaedwards
Copy link
Contributor

This PR fixes issue #206 using mdbook to make a nicer UX to navigate building secure contracts

@ggrieco-tob
Copy link
Member

Can you show some screenshots of the resulting page?

@damilolaedwards
Copy link
Contributor Author

damilolaedwards commented Feb 16, 2023

Screenshot 2023-02-16 at 1 30 26 PM

Screenshot 2023-02-16 at 1 32 00 PM

Screenshot 2023-02-16 at 1 31 27 PM

Comment on lines 19 to 32
- name: Deploy GitHub Pages
run: |
mdbook build
git worktree add gh-pages
git config user.name "Deploy from CI"
git config user.email ""
cd gh-pages
# Delete the ref to avoid keeping history.
git update-ref -d refs/heads/gh-pages
rm -rf *
mv ../book/* .
git add .
git commit -m "Deploy $GITHUB_SHA to gh-pages"
git push --force --set-upstream origin gh-pages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @elopez the deployment script has been updated, now using the above recommended actions.

Copy link
Member

@elopez elopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great btw! I think we can be a bit more granular with permissions (see suggestions below) but other than that, it's awesome! 💯

.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
damilolaedwards and others added 3 commits February 16, 2023 14:52
Co-authored-by: Emilio López <2642849+elopez@users.noreply.github.com>
Co-authored-by: Emilio López <2642849+elopez@users.noreply.github.com>
Co-authored-by: Emilio López <2642849+elopez@users.noreply.github.com>
@@ -0,0 +1,40 @@
name: Deploy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Deploy GH page. Otherwise if might collide with future gh worklow

@@ -0,0 +1,116 @@
# Summary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this file generated automatically, or should we note in our process that we need to update it every time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we'd need to manually update SUMMARY.md whenever new .md files are added, we'd need to add that to the contribution guidelines

@montyly montyly added this pull request to the merge queue Feb 16, 2023
Merged via the queue into master with commit fbcd7a2 Feb 16, 2023
@montyly montyly deleted the mdbook branch February 16, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants