Include list of non-standard ERC20 tokens #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually not sure if this should be moved to another section... any thoughts? |
|
Yes, I think this should be moved to a separate page. I think we can have separate section per type of issue, and we should list the tokens following an order (alphabetical maybe?) |
0xicingdeath
reviewed
Jul 7, 2023
|
|
||
| ## Missing Revert | ||
|
|
||
| These tokens do not revert when a transfer fails due to missing funds. Protocols that integrate these tokens must include a check for the transfer success status in the function's return value and handle the failure case appropriately. |
There was a problem hiding this comment.
May be worth highlighting specifically that these tokens return booleans that represent success/failure, which is why the return value has to be checked
0xicingdeath
reviewed
Jul 7, 2023
|
|
||
| ## Transfer Hooks | ||
|
|
||
| These tokens include [ERC777](https://eips.ethereum.org/EIPS/eip-777)-like transfer hooks. Protocols that interact with tokens that include transfer hooks must be extra careful to protect against reentrant calls when dealing with these tokens, because control is handed back to the caller upon transfer. This can also affect cross-protocol reentrant calls to `view` functions. |
There was a problem hiding this comment.
This can also affect cross-protocol reentrant calls to
viewfunctions.
which can result in dirty reads?
There was a problem hiding this comment.
What do you mean by "dirty reads"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #68