-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add medusa tests to CI #361
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a5b22b9
removed some lines
ggrieco-tob a3814d8
output to a file and grep result
ggrieco-tob f6cee8e
use no-color and escape special characters
ggrieco-tob 23818e9
fix
ggrieco-tob f4ffffa
added generic medusa config
ggrieco-tob 5b1d14e
more medusa configs
ggrieco-tob d1e5d4b
fixed medusa matching strings
ggrieco-tob e64c03e
fixes
ggrieco-tob f54d0e6
fixes
ggrieco-tob 02aadc7
fixes
ggrieco-tob 1699de7
fixes and disabled other tests
ggrieco-tob dcb2651
format
ggrieco-tob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,184 @@ | ||
| name: Run Medusa tests | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - ".github/workflows/medusa.yml" | ||
| - "program-analysis/echidna/**/*.sol" | ||
| - "program-analysis/echidna/**/*.yml" | ||
| branches: | ||
| - master | ||
| pull_request: | ||
| paths: | ||
| - ".github/workflows/medusa.yml" | ||
| - "program-analysis/echidna/**/*.sol" | ||
| - "program-analysis/echidna/**/*.yml" | ||
| schedule: | ||
| # run CI every day even if no PRs/merges occur | ||
| - cron: "0 12 * * *" | ||
|
|
||
| jobs: | ||
| tests: | ||
| name: ${{ matrix.name }} | ||
| continue-on-error: ${{ matrix.flaky == true }} | ||
| runs-on: ubuntu-22.04 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - name: Exercise 1 | ||
| workdir: program-analysis/echidna/exercises/exercise1/ | ||
| files: solution.sol | ||
| contract: TestToken | ||
| outcome: failure | ||
| expected: 'echidna_test_balance()\" failed after the following call sequence' | ||
| - name: Exercise 2 | ||
| workdir: program-analysis/echidna/exercises/exercise2/ | ||
| files: solution.sol | ||
| contract: TestToken | ||
| outcome: failure | ||
| expected: 'echidna_no_transfer()\" failed after the following call sequence' | ||
| - name: Exercise 3 | ||
| workdir: program-analysis/echidna/exercises/exercise3/ | ||
| files: solution.sol | ||
| contract: TestToken | ||
| outcome: failure | ||
| expected: 'echidna_test_balance()\" failed after the following call sequence' | ||
| - name: Exercise 4 | ||
| workdir: program-analysis/echidna/exercises/exercise4/ | ||
| files: solution.sol | ||
| contract: TestToken | ||
| outcome: failure | ||
| expected: 'transfer(address,uint256)\" resulted in an assertion failure after the following call sequence:' | ||
| # - name: Exercise 5 | ||
| # workdir: dvdefi/ | ||
| # files: . | ||
| # config: naivereceiver.yaml | ||
| # crytic-args: --hardhat-ignore-compile | ||
| # contract: NaiveReceiverEchidna | ||
| # outcome: failure | ||
| # expected: 'echidna_test_contract_balance:\s*failed' | ||
| # - name: Exercise 6 | ||
| # workdir: dvdefi/ | ||
| # files: . | ||
| # config: unstoppable.yaml | ||
| # crytic-args: --hardhat-ignore-compile | ||
| # contract: UnstoppableEchidna | ||
| # outcome: failure | ||
| # expected: 'echidna_testFlashLoan:\s*failed' | ||
| # - name: Exercise 7 | ||
| # workdir: dvdefi/ | ||
| # files: . | ||
| # config: sideentrance.yaml | ||
| # crytic-args: --hardhat-ignore-compile | ||
| # contract: SideEntranceEchidna | ||
| # outcome: failure | ||
| # expected: 'testPoolBalance():\s*failed' | ||
| - name: TestToken | ||
| workdir: program-analysis/echidna/example/ | ||
| files: testtoken.sol | ||
| contract: TestToken | ||
| outcome: failure | ||
| expected: 'echidna_balance_under_1000()\" failed after the following call sequence' | ||
| - name: Multi | ||
| workdir: program-analysis/echidna/example/ | ||
| files: multi.sol | ||
| contract: C | ||
| config: filter.yaml | ||
| outcome: failure | ||
| expected: 'echidna_state4()\" failed after the following call sequence' | ||
| - name: Assert | ||
| workdir: program-analysis/echidna/example/ | ||
| files: assert.sol | ||
| config: assert.yaml | ||
| contract: Incrementor | ||
| outcome: failure | ||
| expected: 'inc(uint256)\" resulted in an assertion failure after the following call sequence' | ||
| - name: PopsicleBroken | ||
| workdir: program-analysis/echidna/example/ | ||
| files: PopsicleBroken.sol | ||
| solc-version: 0.8.4 | ||
| contract: PopsicleBroken | ||
| outcome: failure | ||
| expected: 'PopsicleBroken.totalBalanceAfterTransferIsPreserved(address,uint256)\" resulted in an assertion failure after the following call sequence' | ||
| - name: PopsicleFixed | ||
| workdir: program-analysis/echidna/example/ | ||
| files: PopsicleFixed.sol | ||
| solc-version: 0.8.4 | ||
| contract: PopsicleFixed | ||
| outcome: success | ||
| expected: '\[PASSED\] Assertion Test: PopsicleFixed.totalBalanceAfterTransferIsPreserved(address,uint256)' | ||
| - name: TestDepositWithPermit | ||
| workdir: program-analysis/echidna/example/ | ||
| files: TestDepositWithPermit.sol | ||
| solc-version: 0.8.0 | ||
| config: testdeposit.yaml | ||
| contract: TestDepositWithPermit | ||
| outcome: success | ||
| expected: '\[PASSED\] Assertion Test: TestDepositWithPermit.testERC20PermitDeposit(uint256)' | ||
| # - name: MultiABI | ||
| # workdir: program-analysis/echidna/example/ | ||
| # files: allContracts.sol | ||
| # solc-version: 0.8.0 | ||
| # config: allContracts.yaml | ||
| # contract: EchidnaTest | ||
| # outcome: failure | ||
| # expected: 'test_flag_is_false():\s*failed' | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Checkout Damn Vulnerable DeFi solutions | ||
| uses: actions/checkout@v4 | ||
| if: startsWith(matrix.workdir, 'dvdefi') | ||
| with: | ||
| repository: crytic/damn-vulnerable-defi-echidna | ||
| ref: solutions | ||
| path: ${{ matrix.workdir }} | ||
|
|
||
| - name: Set up Nodejs | ||
| uses: actions/setup-node@v3 | ||
| if: startsWith(matrix.workdir, 'dvdefi') | ||
| with: | ||
| node-version: 16 | ||
|
|
||
| - name: Install dependencies and compile | ||
| if: startsWith(matrix.workdir, 'dvdefi') | ||
| run: | | ||
| yarn install --frozen-lockfile | ||
| npx hardhat compile --force | ||
| working-directory: ${{ matrix.workdir }} | ||
|
|
||
| - name: Go setup | ||
| uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: "^1.18.1" | ||
|
|
||
| - name: Install medusa | ||
| run: | | ||
| git clone https://github.com/crytic/medusa.git | ||
| cd medusa | ||
| go build -o medusa -v . | ||
| go install -v . | ||
| sudo cp medusa /usr/bin | ||
| pip install crytic-compile solc-select | ||
|
|
||
| - name: Run Medusa | ||
| continue-on-error: true | ||
| working-directory: ${{ matrix.workdir }} | ||
| run: | | ||
| solc-select install ${{ matrix.solc-version || '0.8.0' }} | ||
| solc-select use ${{ matrix.solc-version || '0.8.0' }} | ||
| medusa fuzz --compilation-target ${{ matrix.files }} --target-contracts ${{ matrix.contract }} --no-color --test-limit 100000 --config medusa.json > ${{ matrix.files }}.out || true | ||
|
|
||
| - name: Verify that the output is correct | ||
| working-directory: ${{ matrix.workdir }} | ||
| run: | | ||
| if grep -q "${{ matrix.expected }}" "${{ matrix.files }}.out"; then | ||
| echo "Output matches" | ||
| else | ||
| echo "Output mismatch. Expected something matching '${{ matrix.expected }}'. Got the following:" | ||
| cat "${{ matrix.files }}.out" | ||
| exit 1 | ||
| fi | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| { | ||
| "fuzzing": { | ||
| "workers": 10, | ||
| "workerResetLimit": 50, | ||
| "timeout": 0, | ||
| "testLimit": 0, | ||
| "callSequenceLength": 100, | ||
| "corpusDirectory": "", | ||
| "coverageEnabled": true, | ||
| "targetContracts": [], | ||
| "targetContractsBalances": [], | ||
| "constructorArgs": {}, | ||
| "deployerAddress": "0x30000", | ||
| "senderAddresses": ["0x10000", "0x20000", "0x30000"], | ||
| "blockNumberDelayMax": 60480, | ||
| "blockTimestampDelayMax": 604800, | ||
| "blockGasLimit": 125000000, | ||
| "transactionGasLimit": 12500000, | ||
| "testing": { | ||
| "stopOnFailedTest": true, | ||
| "stopOnFailedContractMatching": false, | ||
| "stopOnNoTests": true, | ||
| "testAllContracts": false, | ||
| "traceAll": false, | ||
| "assertionTesting": { | ||
| "enabled": true, | ||
| "testViewMethods": false, | ||
| "panicCodeConfig": { | ||
| "failOnCompilerInsertedPanic": false, | ||
| "failOnAssertion": true, | ||
| "failOnArithmeticUnderflow": false, | ||
| "failOnDivideByZero": false, | ||
| "failOnEnumTypeConversionOutOfBounds": false, | ||
| "failOnIncorrectStorageAccess": false, | ||
| "failOnPopEmptyArray": false, | ||
| "failOnOutOfBoundsArrayAccess": false, | ||
| "failOnAllocateTooMuchMemory": false, | ||
| "failOnCallUninitializedVariable": false | ||
| } | ||
| }, | ||
| "propertyTesting": { | ||
| "enabled": true, | ||
| "testPrefixes": ["echidna_"] | ||
| }, | ||
| "optimizationTesting": { | ||
| "enabled": false, | ||
| "testPrefixes": ["optimize_"] | ||
| } | ||
| }, | ||
| "chainConfig": { | ||
| "codeSizeCheckDisabled": true, | ||
| "cheatCodes": { | ||
| "cheatCodesEnabled": true, | ||
| "enableFFI": false | ||
| } | ||
| } | ||
| }, | ||
| "compilation": { | ||
| "platform": "crytic-compile", | ||
| "platformConfig": { | ||
| "target": ".", | ||
| "solcVersion": "", | ||
| "exportDirectory": "", | ||
| "args": [] | ||
| } | ||
| }, | ||
| "logging": { | ||
| "level": "info", | ||
| "logDirectory": "", | ||
| "noColor": false | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "fuzzing": { | ||
| "testing": { | ||
| "propertyTesting": { | ||
| "enabled": true, | ||
| "testPrefixes": ["echidna_"] | ||
| } | ||
| } | ||
| }, | ||
| "compilation": { | ||
| "platform": "crytic-compile", | ||
| "platformConfig": { | ||
| "target": ".", | ||
| "solcVersion": "", | ||
| "exportDirectory": "", | ||
| "args": [] | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "fuzzing": { | ||
| "testing": { | ||
| "propertyTesting": { | ||
| "enabled": true, | ||
| "testPrefixes": ["echidna_"] | ||
| } | ||
| } | ||
| }, | ||
| "compilation": { | ||
| "platform": "crytic-compile", | ||
| "platformConfig": { | ||
| "target": ".", | ||
| "solcVersion": "", | ||
| "exportDirectory": "", | ||
| "args": [] | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "fuzzing": { | ||
| "testing": { | ||
| "propertyTesting": { | ||
| "enabled": true, | ||
| "testPrefixes": ["echidna_"] | ||
| } | ||
| } | ||
| }, | ||
| "compilation": { | ||
| "platform": "crytic-compile", | ||
| "platformConfig": { | ||
| "target": ".", | ||
| "solcVersion": "", | ||
| "exportDirectory": "", | ||
| "args": [] | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| { | ||
| "fuzzing": { | ||
| "workers": 10, | ||
| "workerResetLimit": 50, | ||
| "timeout": 0, | ||
| "testLimit": 0, | ||
| "callSequenceLength": 100, | ||
| "corpusDirectory": "", | ||
| "coverageEnabled": true, | ||
| "targetContracts": [], | ||
| "targetContractsBalances": [], | ||
| "constructorArgs": {}, | ||
| "deployerAddress": "0x30000", | ||
| "senderAddresses": ["0x10000", "0x20000", "0x30000"], | ||
| "blockNumberDelayMax": 60480, | ||
| "blockTimestampDelayMax": 604800, | ||
| "blockGasLimit": 125000000, | ||
| "transactionGasLimit": 12500000, | ||
| "testing": { | ||
| "stopOnFailedTest": true, | ||
| "stopOnFailedContractMatching": false, | ||
| "stopOnNoTests": true, | ||
| "testAllContracts": false, | ||
| "traceAll": false, | ||
| "assertionTesting": { | ||
| "enabled": true, | ||
| "testViewMethods": false, | ||
| "panicCodeConfig": { | ||
| "failOnCompilerInsertedPanic": false, | ||
| "failOnAssertion": true, | ||
| "failOnArithmeticUnderflow": false, | ||
| "failOnDivideByZero": false, | ||
| "failOnEnumTypeConversionOutOfBounds": false, | ||
| "failOnIncorrectStorageAccess": false, | ||
| "failOnPopEmptyArray": false, | ||
| "failOnOutOfBoundsArrayAccess": false, | ||
| "failOnAllocateTooMuchMemory": false, | ||
| "failOnCallUninitializedVariable": false | ||
| } | ||
| }, | ||
| "propertyTesting": { | ||
| "enabled": true, | ||
| "testPrefixes": ["property_"] | ||
| }, | ||
| "optimizationTesting": { | ||
| "enabled": true, | ||
| "testPrefixes": ["optimize_"] | ||
| } | ||
| }, | ||
| "chainConfig": { | ||
| "codeSizeCheckDisabled": true, | ||
| "cheatCodes": { | ||
| "cheatCodesEnabled": true, | ||
| "enableFFI": false | ||
| } | ||
| } | ||
| }, | ||
| "compilation": { | ||
| "platform": "crytic-compile", | ||
| "platformConfig": { | ||
| "target": ".", | ||
| "solcVersion": "", | ||
| "exportDirectory": "", | ||
| "args": [] | ||
| } | ||
| }, | ||
| "logging": { | ||
| "level": "info", | ||
| "logDirectory": "", | ||
| "noColor": false | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we refactor this into a bash script that can be run locally to reproduce CI failures and just run the bash script in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but IMHO what we need is to have an medusa action here. I think @elopez can draft one when he is around, so this code will be reduced and have same shape as the echidna one.