Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.11 - Fix 447 #459

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Support Python 3.11 - Fix 447 #459

merged 4 commits into from
Oct 18, 2023

Conversation

Cherrg
Copy link
Contributor

@Cherrg Cherrg commented May 7, 2023

Support Python 3.11

  • I have added an entry to CHANGELOG.md, or an entry is not needed for this change

    • this should be done by the package maintainer, when a new version is released
  • some of the problems are introduced by fixed requirements introduced in version 0.15.1.0

  • build will run successfully with python3.11

    • tested on linux (nox -s build_executables_current_platform)
    • develop mode is working nox -s develop

Summary of changes

Test plan

Tested by running nox

nox > * tests-3.11: success
nox > * lint: failed
nox > * docs: success
nox > * cover: success

One of the linting errors is also handled with this PR. This change/PR has nothing to do with failed lint tests. They should be handled separately.
What failed?

  • some datatypes - test by mypy
gdbgui/server/constants.py:14: error: Argument 1 to "Path" has incompatible type "Optional[Any]"; expected "Union[str, PathLike[str]]"  [arg-type]
gdbgui/server/sessionmanager.py:67: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
gdbgui/server/sessionmanager.py:103: error: Argument 1 to "IoManager" has incompatible type "FileIO"; expected "BufferedWriter"  [arg-type]
gdbgui/server/sessionmanager.py:104: error: Argument 2 to "IoManager" has incompatible type "FileIO"; expected "BufferedReader"  [arg-type]
  • some missing dist files - test by check-manifest
lists of files in version control and sdist do not match!
missing from VCS:
  gdbgui/static/js/dashboard.js
  gdbgui/static/js/dashboard.js.map
  gdbgui/static/js/main.js
  gdbgui/static/js/main.js.map

Cherrg added 4 commits May 7, 2023 18:04
- update greenlet version to latest version (currently 2.0.2)
- update nox build instructions
  - change python version to 3.11
  - update PyInstaller version
- error messages related to typed-ast, which was loaded by mypy
- the comment has to be in an extra line
@Cherrg Cherrg changed the title Fix 447 Support Python 3.11 - Fix 447 May 7, 2023
@brandonros
Copy link

python3 -m pip install git+https://github.com/Cherrg/gdbgui.git@fix_447

http://127.0.0.1:5000/static/js/dashboard.js?_= 404s?

@jpihl
Copy link

jpihl commented Aug 11, 2023

It seems files in /static/js need to be generated. I don't know why this is not done when installing directly from Git.

I did the following dirty hack to get gdbgui working with python3.11 on Ubuntu 23.04:

pipx install git+https://github.com/Cherrg/gdbgui.git@fix_447
cd /tmp
git clone git+https://github.com/Cherrg/gdbgui.git@fix_447
cd gdbgui
npm install
npm run build
cp -r gdbgui/static/js ~/.local/pipx/venvs/gdbgui/lib/python3.11/site-packages/gdbgui/static

@enathang
Copy link

Hello! What is the status of the PR?

Happy to jump in and help, but I don't see any issues tbh.

@cs01 cs01 merged commit f869684 into cs01:master Oct 18, 2023
@cs01
Copy link
Owner

cs01 commented Oct 18, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gdbgui is not compatible with Python 3.11
5 participants