Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get public share methods also return the share password now #113

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Mar 12, 2021

For some alternative public share authentication methods we need to be able to access the public share password. Some more details are documented here: #110

@C0rby C0rby requested a review from labkode as a code owner March 12, 2021 11:28
@C0rby C0rby force-pushed the public-link-get-share branch 2 times, most recently from 4c13095 to cd9d6cb Compare March 15, 2021 14:00
@labkode
Copy link
Member

labkode commented Mar 15, 2021

@C0rby let's call the field password_hash instead, I think it brings more semantic to someone implementing the API.
The rest looks good.

For some alternative public share authentication methods we need to be able to access the public share password. Some more details are documented here: cs3org#110
@C0rby
Copy link
Contributor Author

C0rby commented Mar 16, 2021

@labkode, I renamed the field and rebased the PR so now it should be mergable.

@labkode labkode merged commit 2f8f5a0 into cs3org:master Mar 17, 2021
@C0rby C0rby deleted the public-link-get-share branch March 17, 2021 09:50
C0rby pushed a commit to C0rby/cs3apis that referenced this pull request Mar 23, 2021
Deprecated the changes from cs3org#113
and enhanced the api to support signature based authentication for
public links.
C0rby pushed a commit to C0rby/cs3apis that referenced this pull request Mar 25, 2021
Deprecated the changes from cs3org#113
and enhanced the api to support signature based authentication for
public links.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants