Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new OpenInApp request/response #121

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

glpatcern
Copy link
Member

This will eventually supersede OpenFileInAppProvider.

The rationale being that OpenInApp generically refers to refs, i.e. files AND directories, and a new optional parameter app was added, to allow:

  1. In case of folders, to specify the app as the default logic to map mimetypes to apps cannot apply
  2. In case of files, to allow overriding the default logic and support the case where the user asks to "Open with..." and multiple applications are registered for the same mimetype (typical case: .docx -> MS Office Online, OnlyOffice, Collabora Online).

This will eventually supersede OpenFileInAppProvider
Copy link
Contributor

@SamuAlfageme SamuAlfageme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All in for this open request version in steroids! 🙌

Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add the optional app field to the current request? If it's empty, do what you're doing now, else the changed implementation

@glpatcern
Copy link
Member Author

Maybe just add the optional app field to the current request? If it's empty, do what you're doing now, else the changed implementation

Not sure I understand - this is precisely what this PR is doing. Or do you mean to modify also the OpenFileInAppProvider request? But the idea is to deprecate it - essentially have it renamed to OpenInApp, without references to File.

@labkode labkode merged commit 62377dd into cs3org:main Apr 27, 2021
glpatcern added a commit to glpatcern/cs3apis that referenced this pull request May 21, 2021
glpatcern added a commit to glpatcern/cs3apis that referenced this pull request May 21, 2021
labkode added a commit that referenced this pull request May 27, 2021
Co-authored-by: Hugo Labrador <labkode@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants