-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new OpenInApp request/response #121
Conversation
This will eventually supersede OpenFileInAppProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! All in for this open request version in steroids! 🙌
ecf0dd5
to
49f4401
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just add the optional app
field to the current request? If it's empty, do what you're doing now, else the changed implementation
Not sure I understand - this is precisely what this PR is doing. Or do you mean to modify also the |
49f4401
to
fcbcc8f
Compare
Co-authored-by: Hugo Labrador <labkode@users.noreply.github.com>
This will eventually supersede
OpenFileInAppProvider
.The rationale being that
OpenInApp
generically refers toref
s, i.e. files AND directories, and a new optional parameterapp
was added, to allow:.docx
-> MS Office Online, OnlyOffice, Collabora Online).