first prototype for the permissions service api #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ishank011 could you review this one please? |
refs
reviewed
Dec 10, 2021
|
@C0rby rebase? 👼 |
|
Reva implementation lives in cs3org/reva#2341 |
C0rby
force-pushed
the
permissions-service
branch
3 times, most recently
from
acad4b0
to
5caea34
Compare
|
Ah, I messed something up. There are changes in this PR which are not from me. I'll fix that and then it should be good to go. |
C0rby
force-pushed
the
permissions-service
branch
from
5caea34
to
e175368
Compare
|
I don't really know why this is here: https://github.com/cs3org/cs3apis/pull/161/files#diff-b04b38d4e36f7a7171aeb211bf933eaf36d41d9866ebbc3639f673f84dc350aeL5710-R5906. Rebasing didn't remove it. I don't find any place where I am touching this in the proto files.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proposed CS3 API extension to introduce a permissions service.
Currently this API is read-only but eventually should also allow to set or update permissions / assignments.