Added a nil check for resp.GetError() in the EOS gRPC client. This fi…

…xes a nil pointer dereference in the RollbackToVersion method (#4896) Co-authored-by: Jesse Geens <jgeens@cern.ch>
cs3org · Oct 21, 2024 · 10664f4 · 10664f4
1 parent d2b2c10
commit 10664f4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/changelog/unreleased/restorefileversion-nilptr.md b/changelog/unreleased/restorefileversion-nilptr.md
@@ -0,0 +1,3 @@
+Bugfix: fix nilpointer error in RollbackToVersion
+
+https://github.com/cs3org/reva/pull/4896
diff --git a/pkg/eosclient/eosgrpc/eosgrpc.go b/pkg/eosclient/eosgrpc/eosgrpc.go
@@ -1544,8 +1544,9 @@ func (c *Client) RollbackToVersion(ctx context.Context, auth eosclient.Authoriza
 		return errtypes.InternalError(fmt.Sprintf("nil response for uid: '%s' ", auth.Role.UID))
 	}
 
-	log.Info().Str("func", "RollbackToVersion").Int64("errcode", resp.GetError().Code).Str("errmsg", resp.GetError().Msg).Msg("grpc response")
-
+	if resp.GetError() != nil {
+		log.Info().Str("func", "RollbackToVersion").Int64("errcode", resp.GetError().Code).Str("errmsg", resp.GetError().Msg).Msg("grpc response")
+	}
 	return err
 }