fix response format of the sharees API

cs3org · Aug 4, 2021 · 9dd8e7b · 9dd8e7b
1 parent a71d6bb
commit 9dd8e7b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/changelog/unreleased/fix-sharees-api.md b/changelog/unreleased/fix-sharees-api.md
@@ -0,0 +1,5 @@
+Bugfix: Fix response format of the sharees API 
+
+The sharees API wasn't returning the users and groups arrays correctly.
+
+https://github.com/cs3org/reva/pull/1954
diff --git a/internal/http/services/owncloud/ocs/conversions/main.go b/internal/http/services/owncloud/ocs/conversions/main.go
@@ -146,21 +146,21 @@ type ShareData struct {
 // ShareeData holds share recipient search results
 type ShareeData struct {
 	Exact   *ExactMatchesData `json:"exact" xml:"exact"`
-	Users   []*MatchData      `json:"users" xml:"users"`
-	Groups  []*MatchData      `json:"groups" xml:"groups"`
-	Remotes []*MatchData      `json:"remotes" xml:"remotes"`
+	Users   []*MatchData      `json:"users" xml:"users>element"`
+	Groups  []*MatchData      `json:"groups" xml:"groups>element"`
+	Remotes []*MatchData      `json:"remotes" xml:"remotes>element"`
 }
 
 // ExactMatchesData hold exact matches
 type ExactMatchesData struct {
-	Users   []*MatchData `json:"users" xml:"users"`
-	Groups  []*MatchData `json:"groups" xml:"groups"`
-	Remotes []*MatchData `json:"remotes" xml:"remotes"`
+	Users   []*MatchData `json:"users" xml:"users>element"`
+	Groups  []*MatchData `json:"groups" xml:"groups>element"`
+	Remotes []*MatchData `json:"remotes" xml:"remotes>element"`
 }
 
 // MatchData describes a single match
 type MatchData struct {
-	Label string          `json:"label" xml:"label"`
+	Label string          `json:"label" xml:"label,omitempty"`
 	Value *MatchValueData `json:"value" xml:"value"`
 }