Merge pull request #4476 from butonic/no-need-to-unmark-postprocessin…

…g-when-it-was-not-started no need to unmark postprocessing when it was not started
cs3org · Jan 24, 2024 · a3e8b04 · a3e8b04
2 parents f9ec0fa + b5b558d
commit a3e8b04
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/changelog/unreleased/no-need-to-unmark-postprocessing-when-it-was-not-started.md b/changelog/unreleased/no-need-to-unmark-postprocessing-when-it-was-not-started.md
@@ -0,0 +1,3 @@
+Bugfix: no need to unmark postprocessing when it was not started
+
+https://github.com/cs3org/reva/pull/4476
diff --git a/pkg/storage/utils/decomposedfs/upload/session.go b/pkg/storage/utils/decomposedfs/upload/session.go
@@ -295,7 +295,7 @@ func (s *OcisSession) MTime() time.Time {
 	return t
 }
 
-// IsProcessing returns true if all bytes have been received. The node then has entered postprocessing state.
+// IsProcessing returns true if all bytes have been received. The session then has entered postprocessing state.
 func (s *OcisSession) IsProcessing() bool {
 	return s.info.Size == s.info.Offset
 }

diff --git a/pkg/storage/utils/decomposedfs/upload/upload.go b/pkg/storage/utils/decomposedfs/upload/upload.go
@@ -191,7 +191,7 @@ func (session *OcisSession) FinishUpload(ctx context.Context) error {
 
 	n, err := session.store.CreateNodeForUpload(session, attrs)
 	if err != nil {
-		session.store.Cleanup(ctx, session, true, false, true)
+		session.store.Cleanup(ctx, session, true, false, false)
 		return err
 	}