Skip to content

Commit

Permalink
Also removed obsoleted comment
Browse files Browse the repository at this point in the history
As the frontend uses a separate tab, the folderurl argument
becomes less relevant and WOPI will hide its breadcrumb when missing
  • Loading branch information
glpatcern committed Sep 6, 2021
1 parent ac1146a commit d35480a
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions pkg/app/provider/wopi/wopi.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,6 @@ func (p *wopiProvider) GetAppURL(ctx context.Context, resource *provider.Resourc
q.Add("fileid", resource.GetId().OpaqueId)
q.Add("endpoint", resource.GetId().StorageId)
q.Add("viewmode", viewMode.String())
// TODO the folder URL should be resolved as e.g. `'https://cernbox.cern.ch/index.php/apps/files/?dir=' + filepath.Dir(req.Ref.GetPath())`
// or should be deprecated/removed altogether, needs discussion and decision.
// q.Add("folderurl", "...")
u, ok := ctxpkg.ContextGetUser(ctx)
if ok { // else defaults to "Anonymous Guest"
q.Add("username", u.Username)
Expand Down

0 comments on commit d35480a

Please sign in to comment.