Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] bug demonstration scenario for owncloud/ocis/issues/751 #1277

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

individual-it
Copy link
Contributor

this demonstrates the bug in owncloud/ocis/issues/751

Its useful to know when the bug gets fixed, see https://dev.to/jankaritech/should-you-write-acceptance-tests-for-bugs-2bfm

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also delete the scenario the same as was deleted in owncloud/ocis#752 ?

@phil-davis
Copy link
Contributor

Note: the similar PR to owncloud/ocis is owncloud/ocis#752

@individual-it
Copy link
Contributor Author

Also delete the scenario the same as was deleted in owncloud/ocis#752 ?

it never got ported here

@phil-davis
Copy link
Contributor

it never got ported here

https://github.com/cs3org/reva/blob/master/tests/acceptance/features/apiOcisSpecific/apiShareManagementBasic-deleteShare.feature exists - but actually over time it got changed into a good scenario, that does effectively the same test as what is now in core https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiShareManagementBasicToShares/deleteShareFromShares.feature#L32

The one here in cs3org/reva is not demonstrating any different behaviour to the oC10 API test suite. We can delete it.

Do that in this PR? Or in a separate PR?

@phil-davis phil-davis self-requested a review October 26, 2020 10:24
@individual-it
Copy link
Contributor Author

The bug mentioned in the file is not the same as talked about here, but still delete the file because it actually does not demonstrate the bug, nether the one that is mentioned here, nor the one that it claims to demonstrate

@ishank011 ishank011 merged commit e27c14f into cs3org:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants