Move mime types registration to storageprovider #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
force-pushed
the
appprovider-fix-1234
branch
2 times, most recently
from
bc55e70
to
0008c2d
Compare
glpatcern
changed the title
ishank011
previously approved these changes
Oct 29, 2020
|
@glpatcern can you rebase? |
glpatcern
force-pushed
the
appprovider-fix-1234
branch
from
19f0772
to
31278f3
Compare
Done! I guess it can be merged once the build finishes... |
ishank011
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with @SamuAlfageme: the yet unreleased custom mimetypes registration (#1233) to support
.zmdneeds to be moved to the storageprovider, in order to support the case of (remote) storageproviders running separately from appproviders.On top, PR #1234 has a bug in case the WOPI bridge is not configured. This patch fixes that as well.