return share-types in ocs propfind responses

[C0rby]

Implements owncloud/ocis#929

[labkode]

This change is very heavy on the server side.
Please add a config option to the dav service: include-shares-in-propfind and set it as false by default.
These behaviour will be enabled only when this option is true.

[butonic]

@corby the ListShares rpc can take a path argument. Use it to get a list of all grants in a folder instead of every file individually. You can send that request in parralel to the ListContainer.

When the ListContainer request has returned you can prepare a map[fileid]metadata instead of the current list.
When both coroutines have returned you can iterate over the grants and apply them by looking up the metadata using the fileid.

@labkode that should not be heavy.

[labkode]

@butonic that is a good improvement, however that config option is needed to enable or disable it on demand. We don't use it for example.

[C0rby]

So after talking with @butonic, I rewrote it and we read the shares directly during the ListFolder call from the extended attributes.
This should be more performant but only works for user shares right now. Public link shares will be tackled some other time.

[butonic]

related:

• eos: store share id in inherited xattr #543
• delete reference when unsharing a resource #1275
• storageprovider should persist share creator #93

[kulmann]

Code looks good

[kulmann]

I was confused by the "0" and needed to ask. For the record, it would be really cool to have constants for the share types.

[C0rby]

Yes, I agree. 👍