Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support site authorization status in Mentix #1398

Merged
merged 21 commits into from
Jan 19, 2021
Merged

Support site authorization status in Mentix #1398

merged 21 commits into from
Jan 19, 2021

Conversation

Daniel-WWU-IT
Copy link
Contributor

@Daniel-WWU-IT Daniel-WWU-IT commented Jan 14, 2021

This enhancement adds support for a site authorization status to Mentix. This way, sites registered via a web app can now be excluded until authorized manually by an administrator.

Furthermore, Mentix now sets the scheme for Prometheus targets. This allows us to also support monitoring of sites that do not support the default HTTPS scheme.

(Some very minor changes were also made in the SDK which I include here for the sake of not creating an extra PR)

@Daniel-WWU-IT Daniel-WWU-IT marked this pull request as draft January 15, 2021 12:52
@Daniel-WWU-IT Daniel-WWU-IT changed the title Set scheme for Prometheus targets in Mentix Support site authorization status in Mentix Jan 15, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jan 15, 2021

This pull request introduces 4 alerts when merging c39ee4f into 47119be - view on LGTM.com

new alerts:

  • 4 for Useless assignment to local variable

@Daniel-WWU-IT Daniel-WWU-IT marked this pull request as ready for review January 15, 2021 16:29
@labkode labkode merged commit 3ebc86f into cs3org:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants