Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Port drone pipeline definition to starlark #1528

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

aduffeck
Copy link
Contributor

@aduffeck aduffeck commented Mar 9, 2021

This allows for keeping the pipeline definition much more DRY and easier to maintain and extend.

@aduffeck aduffeck requested a review from labkode as a code owner March 9, 2021 14:57
@update-docs
Copy link

update-docs bot commented Mar 9, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@aduffeck aduffeck changed the title Port drone pipeline definition to starlark [tests-only] Port drone pipeline definition to starlark Mar 9, 2021
@SamuAlfageme SamuAlfageme self-requested a review March 9, 2021 15:14
@aduffeck
Copy link
Contributor Author

@SamuAlfageme Apparently the drone config wasn't picked up. Do you know if it's still a server side issue or if the problem is with the definition file?

@SamuAlfageme
Copy link
Contributor

@aduffeck did a successful check on my fork on SamuAlfageme#56 - merging now that the CI is quiet.

@SamuAlfageme SamuAlfageme merged commit 117adad into cs3org:master Mar 10, 2021
ffurano pushed a commit to ffurano/reva that referenced this pull request Apr 19, 2021
* Port drone pipeline definition to starlark

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants