Use UidNumber and GidNumber fields in User objects #1573
Conversation
sudo-sturbia
force-pushed
the
user-fields
branch
from
de34f48
to
7aad73e
Compare
sudo-sturbia
force-pushed
the
user-fields
branch
2 times, most recently
from
fabd746
to
0cb5c88
Compare
|
@sudo-sturbia majorly looks good, nice work! I'll test it since you don't have access to an EOS instance so there might be a delay in merging. We're working on getting EOS tests integrated in the CI so we should have that soon Meanwhile, please rebase and fix the failing integration tests. |
sudo-sturbia
force-pushed
the
user-fields
branch
4 times, most recently
from
cb79532
to
999730a
Compare
|
@ishank011 Hi, I thought I'd let you know the latest updates: I looked at the integration tests and was able to find the errors, the changes are mainly in 999730a and e685753. As for the old commits, struct tags for |
There was a problem hiding this comment.
@sudo-sturbia LGTM! Good work on finding the issues with the integration tests. The LGTM tool is not that mature yet, so we do see intermittent build failures sometimes; we can ignore that. I'll test the changes tomorrow and merge.
That sounds great. Thank you! |
Update getUser to verify that uid and gid are not zero to avoid granting access to users by mistake.
Remove "opaque" map and use the correct value for "uid_number".
Update assertGetUserByClaimResponses integration test to verify that user is not nil.
sudo-sturbia
force-pushed
the
user-fields
branch
from
f4d68cc
to
1db79ca
Compare
No description provided.