Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move shares folder out to a separate mount and handle ref conflicts #1584

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Move shares folder out to a separate mount and handle ref conflicts #1584

wants to merge 5 commits into from

Conversation

ishank011
Copy link
Contributor

No description provided.

@ishank011 ishank011 requested a review from labkode as a code owner March 25, 2021 17:59
@ishank011 ishank011 marked this pull request as draft March 25, 2021 18:00
@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2021

This pull request introduces 2 alerts when merging 6941446 into 538c8bd - view on LGTM.com

new alerts:

  • 2 for Off-by-one comparison against length

@ishank011 ishank011 added the needs decision Needs decision before commiting to implement label Mar 30, 2021
@ishank011 ishank011 force-pushed the myshares branch 2 times, most recently from 48da7e2 to 2efab01 Compare April 7, 2021 14:51
@ishank011 ishank011 mentioned this pull request Jul 9, 2021
Closed
@butonic butonic mentioned this pull request Oct 15, 2021
Closed
3 tasks
@butonic
Copy link
Contributor

butonic commented Oct 15, 2021

@ishank011 I think this can be closed in favor of #2023

@ishank011 ishank011 changed the title Move shares folder out from home directory to a separate mount Move shares folder out to a separate mount and handle ref conflicts Jun 13, 2022
@ishank011 ishank011 mentioned this pull request Jun 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern will be requested when the pull request is marked ready for review glpatcern is a code owner

@diocas diocas Awaiting requested review from diocas diocas will be requested when the pull request is marked ready for review diocas is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs decision Needs decision before commiting to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishank011 @butonic