Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spaces 1/2] initial ListStorageSpaces implementation #1802

Merged
merged 5 commits into from
Jul 8, 2021
Merged

[spaces 1/2] initial ListStorageSpaces implementation #1802

merged 5 commits into from
Jul 8, 2021

Commits on Jul 7, 2021

  1. initial list spaces implementation 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    c5f3bf5 View commit details
    Browse the repository at this point in the history

  2. add changelog 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    6b0404a View commit details
    Browse the repository at this point in the history

  3. clean up code

    @butonic
    David Christofas authored and butonic committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    6298888 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    address small review items

Co-authored-by: Alex Unger <6905948+refs@users.noreply.github.com>
    @butonic @refs
    butonic and refs committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    b6b040f View commit details
    Browse the repository at this point in the history

  5. incorporate review 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    55c5bde View commit details
    Browse the repository at this point in the history