-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use empty array for ocs notifications api #1808
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
@pascalwengerter CI is happy, as soon as it gets approved by QA team I merge it. |
Ping @phil-davis |
Discussing the implemention of this with @refs right now, will update this as soon as we come to a conclusion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine to change. We currently skip the test scenarios that test the notifications behavior - see mentions of ~@notifications-app-required
in .drone.star
If/when notifications start to be added/supported we can easily remove the skipping, and at that point some development effort will provide more than just an empty response.
Fixes #1805
@pascalwengerter