owncloud/ocs: Move to go-chi/chi based URL routing #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
refs
reviewed
Aug 19, 2021
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go
Outdated
Show resolved
Hide resolved
refs
reviewed
Aug 19, 2021
rhafer
force-pushed
the
ocs-to-chi
branch
4 times, most recently
from
a5b87d0
to
cb2feb0
Compare
labkode
reviewed
Aug 30, 2021
rhafer
force-pushed
the
ocs-to-chi
branch
2 times, most recently
from
bfe3095
to
0635784
Compare
refs
previously approved these changes
Aug 31, 2021
This should help with code readability and make it easier to figure out which code is executed for which URL. Closes cs3org#1986
labkode
approved these changes
Sep 1, 2021
refs
approved these changes
Sep 1, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with code readability and make it easier to figure out
which code is executed for which URL.
Closes #1986