Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add archiver and app provider capabilities #2088

Merged
merged 1 commit into from
Sep 23, 2021
Merged

add archiver and app provider capabilities #2088

merged 1 commit into from
Sep 23, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Sep 21, 2021 •
edited
Loading

No description provided.

@update-docs
Copy link

update-docs bot commented Sep 21, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

This was referenced Sep 21, 2021
Closed
Merged
@pascalwengerter pascalwengerter mentioned this pull request Sep 21, 2021
Merged
5 tasks
@wkloucek wkloucek mentioned this pull request Sep 22, 2021
Merged
9 tasks
@wkloucek wkloucek marked this pull request as ready for review September 22, 2021 10:21
@wkloucek wkloucek marked this pull request as draft September 22, 2021 12:12
@ishank011
Copy link
Contributor

@wkloucek can you fix the linter error?

@kulmann
Copy link
Member

kulmann commented Sep 22, 2021

@wkloucek is this ready for review? still marked as a draft PR.
@ishank011 could you please review this with high prio? I'm afraid this is quite urgent for two PRs in web.

kulmann
kulmann reviewed Sep 22, 2021
View reviewed changes
internal/http/services/owncloud/ocs/data/capabilities.go
@@ -110,6 +126,8 @@ type CapabilitiesFiles struct {
Favorites ocsBool `json:"favorites" xml:"favorites"`
BlacklistedFiles []string `json:"blacklisted_files" xml:"blacklisted_files>element" mapstructure:"blacklisted_files"`
TusSupport *CapabilitiesFilesTusSupport `json:"tus_support" xml:"tus_support" mapstructure:"tus_support"`
Archivers []*CapabilitiesArchiver `json:"archivers" xml:"archivers" mapstructure:"archivers"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are multiple archiver or app provider versions available from the backend, how do I know which one is the most recent one? By parsing the versions? Or do you think it makes sense to introduce some MostRecent boolean in the respective capability struct?

ishank011
ishank011 approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kulmann @wkloucek it looks good to me. Should I merge it or do you want to address the MostRecent parameter?

@kulmann
Copy link
Member

kulmann commented Sep 23, 2021

In my PoC I'm using http://npmjs.com/semver to sort the available versions (which also works with strings like v1 and v2). Fine by me to merge. @wkloucek what do you think?

@ishank011 ishank011 marked this pull request as ready for review September 23, 2021 07:06
@ishank011 ishank011 merged commit 41d5a68 into cs3org:master Sep 23, 2021
@ishank011
Copy link
Contributor

Merging it now. Other parameters can be added in separate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann left review comments

@ishank011 ishank011 ishank011 approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @ishank011 @kulmann