Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden decomposedfs and add unit tests #2187

Merged
merged 3 commits into from
Oct 22, 2021
Merged

Conversation

micbar
Copy link
Member

@micbar micbar commented Oct 18, 2021

Follow up of #2152

@update-docs
Copy link

update-docs bot commented Oct 18, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar force-pushed the harden-decomposedfs branch 2 times, most recently from d8782a7 to a300975 Compare October 18, 2021 12:42
@micbar micbar requested a review from refs October 18, 2021 13:31
@micbar micbar marked this pull request as ready for review October 18, 2021 13:32
@micbar micbar requested a review from labkode as a code owner October 18, 2021 13:32
@micbar micbar requested a review from ishank011 October 18, 2021 13:38
pkg/storage/utils/decomposedfs/lookup.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/lookup.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/lookup.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/upload.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/upload.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/upload.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/upload.go Outdated Show resolved Hide resolved
@micbar micbar marked this pull request as draft October 18, 2021 19:26
butonic
butonic previously approved these changes Oct 19, 2021
kobergj
kobergj previously approved these changes Oct 19, 2021
@micbar micbar dismissed stale reviews from kobergj and butonic via d1bdddb October 20, 2021 18:41
@micbar
Copy link
Member Author

micbar commented Oct 20, 2021

@butonic i moved the storage space lookup to the node. pls review again

@micbar micbar marked this pull request as ready for review October 20, 2021 18:46
@C0rby C0rby merged commit 60760bd into cs3org:master Oct 22, 2021
@butonic butonic deleted the harden-decomposedfs branch October 24, 2021 08:27
gmgigi96 pushed a commit to cernbox/reva that referenced this pull request Oct 25, 2021
* lookup space root and tests

* refactor checkQuota

* move storageSpace lookup to node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants