allow users with the list-all-spaces permission to list all spaces #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation is just a quick hack which is definitely not production ready. It should be changed as soon as we have a proper permission system in reva.
C0rby
force-pushed
the
list-all-spaces
branch
from
d196694
to
fc3c653
Compare
ishank011
approved these changes
Oct 27, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR users with the required permission can list all spaces.
This implementation is just a quick hack which is definitely not production ready. It should be changed as soon as we have a proper permission system in reva.
Finding a better mechanism for permission checks is part of our current sprint so this will be changed soon.
Also currently we are the only one using spaces so this shouldn't affect anyone else.