Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of CS3 Lock API for EOS storage driver #2444

Merged
merged 57 commits into from
Apr 22, 2022

Conversation

gmgigi96
Copy link
Member

@gmgigi96 gmgigi96 commented Jan 14, 2022

No description provided.

@update-docs
Copy link

update-docs bot commented Jan 14, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes here and there, let's discuss them later

pkg/storage/utils/eosfs/eosfs.go Outdated Show resolved Hide resolved
pkg/storage/utils/eosfs/eosfs.go Outdated Show resolved Hide resolved
pkg/storage/utils/eosfs/eosfs.go Outdated Show resolved Hide resolved
pkg/storage/utils/eosfs/eosfs.go Outdated Show resolved Hide resolved
@gmgigi96 gmgigi96 force-pushed the eos-lock branch 2 times, most recently from 75ff061 to 10b963b Compare January 28, 2022 16:49
@lgtm-com
Copy link

lgtm-com bot commented Jan 31, 2022

This pull request introduces 2 alerts when merging 19f2b67 into 19246df - view on LGTM.com

new alerts:

  • 2 for Missing error check

@lgtm-com
Copy link

lgtm-com bot commented Jan 31, 2022

This pull request introduces 2 alerts when merging ba469cd into 19246df - view on LGTM.com

new alerts:

  • 2 for Missing error check

@lgtm-com
Copy link

lgtm-com bot commented Jan 31, 2022

This pull request introduces 2 alerts when merging 7a65ebe into 19246df - view on LGTM.com

new alerts:

  • 2 for Missing error check

@lgtm-com
Copy link

lgtm-com bot commented Apr 20, 2022

This pull request introduces 1 alert when merging f39dbd2 into 5ba14cd - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types

Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have tested this now and it all works fine. Some caveats to be addressed in future PRs:

  • Race conditions exist in some cases, and once EOS provides an endpoint to flock a file they will be fixed.
  • Attributes are currently stored on the version folder, but this can be reverted once the propagation of xattrs across versions is implemented in EOS (work in progress). This affects all xattrs, not just the locks.

Given that, the PR can be merged.

Once we reconcile with the edge branch, we could factorize out some common logic out of the decomposedfs and eosfs storage providers.

@labkode labkode merged commit d25a3a7 into cs3org:master Apr 22, 2022
kobergj pushed a commit to kobergj/reva that referenced this pull request Nov 30, 2022
@kobergj kobergj mentioned this pull request Nov 30, 2022
@kobergj kobergj mentioned this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants