Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site accounts update #2599

Closed
wants to merge 37 commits into from
Closed

Conversation

Daniel-WWU-IT
Copy link
Contributor

Yet another PR to update the site accounts (and Mentix):

  • New default site ID
  • Include service type in alerts
  • Naming unified
  • Remove obsolete stuff

@Daniel-WWU-IT Daniel-WWU-IT changed the title Site accounts update [WIP] Site accounts update Mar 14, 2022
@Daniel-WWU-IT Daniel-WWU-IT changed the title [WIP] Site accounts update Site accounts update Mar 16, 2022
@labkode
Copy link
Member

labkode commented Mar 22, 2022

@Daniel-WWU-IT can you rebase the changes?

@Daniel-WWU-IT
Copy link
Contributor Author

@labkode Rebased and (still) green. Can this be merged now?

* Bump CORE_COMMITID

* Bump commit id 2022-03-23
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Daniel, are you sure the rebase worked correctly? It seems the PR brings many more changes than it was supposed to

@Daniel-WWU-IT
Copy link
Contributor Author

Hi Daniel, are you sure the rebase worked correctly? It seems the PR brings many more changes than it was supposed to

Rebase never works for me, and I frankly don't know how to get rid of those superfluous commits...

@Daniel-WWU-IT
Copy link
Contributor Author

Replaced by #2672

@Daniel-WWU-IT Daniel-WWU-IT deleted the siteacc-upd branch March 28, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.