Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update eos-revad dockerfile #2712

Merged
merged 3 commits into from
May 3, 2022

Conversation

jimil749
Copy link
Contributor

@jimil749 jimil749 commented Apr 4, 2022

Updates the dockerfile for revad-eos to not break.

The compressed size of the image is 2.76GB.

/cc @SamuAlfageme

Signed-off-by: Jimil Desai jimildesai42@gmail.com

Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@update-docs
Copy link

update-docs bot commented Apr 4, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@SamuAlfageme SamuAlfageme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, try keeping the Dockerfile lines under 80 chars to improve readability of the Dockerfile

From https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#env

Using \ as a line continuation character for Linux Dockerfiles improves readability.

Dockerfile.revad-eos Outdated Show resolved Hide resolved
Dockerfile.revad-eos Outdated Show resolved Hide resolved
Co-authored-by: Samuel Alfageme <samuel.alfageme@gmail.com>
@jimil749
Copy link
Contributor Author

jimil749 commented Apr 4, 2022

Just built and checked the compressed size of the image locally: 2.59GB
https://hub.docker.com/repository/docker/jimil749/revad-eos-test-2/tags?page=1&ordering=last_updated

Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749 jimil749 requested review from glpatcern and a team as code owners April 5, 2022 07:32
@SamuAlfageme
Copy link
Contributor

SamuAlfageme commented Apr 5, 2022

@jimil749 could you give a go the RUN rm -rf the following dirs:

  • /go
  • /var/lib/rpm/Packages
  • /var/log

... and report back on the size?

@jimil749
Copy link
Contributor Author

jimil749 commented Apr 5, 2022

I added the following line:

RUN rm -rf /go && rm -rf /var/lib/rpm/Packages && rm -rf /var/log

in the Dockerfile but the size appears to be the same around ~2.59GB. Moreover, I am not able to push the image to dockerhub. I get unexpected EOF error

@SamuAlfageme
Copy link
Contributor

Let's merge for the time being and fix the size in a follow-up PR

@SamuAlfageme SamuAlfageme merged commit e62dd05 into cs3org:master May 3, 2022
@jimil749 jimil749 deleted the dockerfile-revad-eos branch May 3, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants