Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue closed. FIXME removed. #3311

Merged
merged 3 commits into from
Oct 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/fix-closed-FIXME.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Remove FIXME

Issue https://github.com/cs3org/reva/issues/2402 is closed.

https://github.com/cs3org/reva/pull/3311
2 changes: 0 additions & 2 deletions internal/grpc/services/ocmshareprovider/ocmshareprovider.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ func (s *service) CreateOCMShare(ctx context.Context, req *ocm.CreateOCMShareReq

// discover share type
sharetype := ocm.Share_SHARE_TYPE_REGULAR
// FIXME: https://github.com/cs3org/reva/issues/2402
protocol, ok := req.Opaque.Map["protocol"]
if ok {
switch protocol.Decoder {
Expand All @@ -172,7 +171,6 @@ func (s *service) CreateOCMShare(ctx context.Context, req *ocm.CreateOCMShareReq
Status: status.NewInternal(ctx, err, "error creating share"),
}, nil
}
// token = protocol FIXME!
}

var sharedSecret string
Expand Down