AppProvider: make CodiMD config non hard-coded #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpatcern
requested review from
labkode,
wkloucek and
ishank011
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
…d hardcoded config
glpatcern
changed the title
micbar
reviewed
Oct 27, 2022
labkode
approved these changes
Nov 3, 2022
vascoguita
pushed a commit
to vascoguita/reva
that referenced
this pull request
Nov 11, 2022
glpatcern
added a commit
to cernbox/reva
that referenced
this pull request
Dec 3, 2022
glpatcern
added a commit
to cernbox/reva
that referenced
this pull request
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to clean up some hardcoded logic to support CodiMD, and make it more streamlined like for other apps.
The custom mimetype JSON file was moved to the appprovider configuration as it's not WOPI driver specific.
The required extra logic to handle the mime types <-> file extensions mapping was implemented in the go-mime package, with a PR due in https://github.com/cubewise-code/go-mime. This is why in this PR I'm pointing to my fork. If there's no active development on go-mime (not unlikely, given that the last activity is from 3 years ago whereas the mime types repo at https://github.com/micnic/mime.json was updated 1 year ago), we should actually consider alternatives.