Disallow moves #4284
Merged
Disallow moves #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduffeck
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
kobergj
requested changes
Oct 25, 2023
| @@ -591,6 +591,12 @@ func (s *service) Move(ctx context.Context, req *provider.MoveRequest) (*provide | |||
| Interface("destination", req.Destination). | |||
| Msg("sharesstorageprovider: Got Move request") | |||
|
|
|||
| if !utils.ResourceIDEqual(req.Source.ResourceId, req.Destination.ResourceId) { | |||
There was a problem hiding this comment.
This implies that Source and Destination are relative references, right? Can't I move them by specific ids only? Wouldn't this fail then?
There was a problem hiding this comment.
That's correct. The sharesstorageprovider works with references where the storage and space ids are hardcoded values and the opaque id is the encoded resource id of the shared resource (in the form <storageid>:<spaceid>:<opaqueid>. The actual referenced resource is selected by path, so it's always gonna be a relative reference.
kobergj
approved these changes
Oct 25, 2023
aduffeck
force-pushed
the
disallow-moves
branch
from
6a59859
to
fe4384d
Compare
kobergj
approved these changes
Oct 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer allow moves between shares, even if they resolve to the same space.