Dynamic storage provider add aliases #4307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmgigi96
approved these changes
Nov 1, 2023
labkode
reviewed
Nov 1, 2023
| @@ -195,7 +192,6 @@ func (b *reg) FindProviders(ctx context.Context, ref *provider.Reference) ([]*re | |||
| } | |||
| } | |||
|
|
|||
| l.Debug().Msgf(">>>>>> match: %+v %+v", match, shardedMatches) | |||
There was a problem hiding this comment.
@javfg can we keep this as Debug?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the problem we found yesterday where it is impossible to resolve storage ids like:
eoshome-a, as those are aliases of real storage ids likeeoshome-i01.We add a new section in the registry config:
And when the storage registry is passed a
storage_idto find its providers, it will ensure if the givenstorage_idis an alias, it will be resolved.Fixes #4303