Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursive trashcan purge #4533

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

dragonchaser
Copy link

Bugfix: Fix recursive trashcan purge

We have fixed a bug in the trashcan purge process that did not delete folder structures recursively.

owncloud/ocis#8473

Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>

Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
@dragonchaser dragonchaser marked this pull request as ready for review February 21, 2024 15:08
Copy link

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to introduced recursion this can have negative impact on runtime performance.

Asynchronous processing is required on the caller - our of scope for this pull request

@dragonchaser dragonchaser merged commit 6d5a4d7 into cs3org:edge Feb 21, 2024
9 checks passed
@dragonchaser dragonchaser deleted the fix-recursive-trashcan-purge branch February 21, 2024 15:36
@micbar
Copy link
Member

micbar commented Feb 21, 2024

Thanks for the patch, but unit tests??

There was no coverage, which made this bug possible.

@micbar micbar mentioned this pull request Feb 26, 2024
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants