Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow updating of ocm shares #4840

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

dragonchaser
Copy link

@dragonchaser dragonchaser commented Sep 9, 2024

Bugfix: Allow update of ocm shares

We fixed a bug that prevented ocm shares to be updated or removed.

owncloud/ocis#9926

Copy link

update-docs bot commented Sep 9, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dragonchaser dragonchaser changed the title allow updateing of ocm shares allow updating of ocm shares Sep 9, 2024
Comment on lines 107 to 111
normalizedDomain := u.Hostname()
if port := u.Port(); port != "" {
normalizedDomain += ":" + port
}
return normalizedDomain, nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fschade is that not part of any other PR? Related to the current breaking ocm setup in web?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@butonic its a leftover from our early suggestion diff... can go away

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, dropped this and combinde the commits to glue the changelog to the change

Signed-off-by: Christian Richter <crichter@owncloud.com>

add changelog

Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic marked this pull request as ready for review September 9, 2024 15:27
@butonic butonic requested review from labkode, glpatcern and a team as code owners September 9, 2024 15:27
@butonic butonic merged commit 5fd1e89 into cs3org:edge Sep 9, 2024
9 of 10 checks passed
@dragonchaser dragonchaser deleted the fix-ocm-share-updates branch September 11, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants