Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate remaining Quota correctly #4897

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Calculate remaining Quota correctly #4897

merged 2 commits into from
Oct 23, 2024

Conversation

kobergj
Copy link
Contributor

@kobergj kobergj commented Oct 22, 2024

Calculates the remaining quota as total-used and does not take free disc space into account.

@kobergj kobergj requested review from a team, labkode and glpatcern as code owners October 22, 2024 14:15
rhafer
rhafer requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the GetAvailableSize from the Blobstore interface again (basically revert b5c3c67) ? Or is that still used anywhere?

@kobergj kobergj requested a review from rhafer October 23, 2024 10:40
@kobergj kobergj merged commit 5b32bad into cs3org:edge Oct 23, 2024
10 checks passed
@kobergj kobergj deleted the RemainingQuota branch October 23, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobergj @rhafer