Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the gateway prefix relative home paths with the mount point #562

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Let the gateway prefix relative home paths with the mount point #562

merged 1 commit into from
Mar 18, 2020

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Mar 16, 2020

fixes #552

@butonic
Let the gateway prefix relative home paths with the mount point
1361c0f 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested a review from labkode as a code owner March 16, 2020 09:42
@labkode
Copy link
Member

labkode commented Mar 16, 2020

@butonic do we need to change anything on CreateHome?

labkode
labkode approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@labkode labkode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@labkode labkode merged commit 89f3599 into cs3org:master Mar 18, 2020
@butonic butonic mentioned this pull request Mar 19, 2020
Merged
@butonic butonic deleted the gateway-should-prefix-relative-gethome branch March 19, 2020 09:46
@butonic butonic mentioned this pull request Mar 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode labkode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetHome mixes internal and external namespace
2 participants
@butonic @labkode