Change percentagused to percentageused #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@labkode this might need testing on your side |
|
@phil-davis this need to be changed at the source. |
|
yes, no probs |
|
done |
|
@ffurano can you update the copy of proto in reva with the new version and adapt the code accordingly? |
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Jul 1, 2020
Follows PR cs3org#903
|
Just made a PR for the compiled go proto |
|
Rebased just now to get fresh CI... |
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Jul 9, 2020
Follows PR cs3org#903
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Aug 20, 2020
Follows PR cs3org#903
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Sep 9, 2020
Follows PR cs3org#903
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Oct 5, 2020
Follows PR cs3org#903
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Oct 6, 2020
Follows PR cs3org#903
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Oct 20, 2020
Follows PR cs3org#903
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Oct 23, 2020
Follows PR cs3org#903
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Nov 10, 2020
Follows PR cs3org#903
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Nov 13, 2020
Follows PR cs3org#903
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Dec 2, 2020
Follows PR cs3org#903
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Dec 2, 2020
Follows PR cs3org#903
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Dec 2, 2020
Follows PR cs3org#903
ishank011
pushed a commit
to ishank011/reva
that referenced
this pull request
Dec 2, 2020
Follows PR cs3org#903
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Dec 3, 2020
Follows PR cs3org#903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO these names can be fixed without created a BC-break problem. The "magic" numbers are still 10 and 11.
But happy to be told where the names are used elsewhere.