Make sure configured paths have no trailing slash #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpatcern
changed the title
DeepDiver1975
approved these changes
May 23, 2024
wkloucek
reviewed
May 24, 2024
Comment on lines
+149
to
+151
| cls.wopiurl = cls.config.get('general', 'wopiurl').strip('/') | ||
| cls.homepath = cls.config.get('general', 'homepath', fallback='/home/username').strip('/') | ||
| cls.recoverypath = cls.config.get('io', 'recoverypath', fallback='/var/spool/wopirecovery').strip('/') |
There was a problem hiding this comment.
@glpatcern are you sure that strip does the right thing?
According to https://www.w3schools.com/python/ref_string_strip.asp, it removes trailing and leading slashes in our case. Which makes the path relative instead of absolute. I noticed it because I have a readonly filesystem in our Kubernetes setup and it tries to write somewhere it should not.
There was a problem hiding this comment.
You're right, sorry for that! Let's not over-engineer this, I will simply revert the change for the OS-level paths (where extra slashes are irrelevant anyway) and leave it for URLs (where the protocol prefix MUST be present)
glpatcern
added a commit
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.