Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling the creation of zmd files in CodiMD #49

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Conversation

glpatcern
Copy link
Member

A new boolean flag disablezip is defined in the config (defaults to False, i.e. previous behavior), which disables
converting a .md file to .zmd, but preserves existing .zmd files.

To be seen if we want to force converting existing .zmd files to .md.

This goes in the direction of fixing #40 though the complete fix would be to integrate the ownCloud file picker and include a public link to pictures in the markdown document.

A new boolean flag `disablezip` is defined in the config
(defaults to False, i.e. previous behavior), which disables
converting a .md file to .zmd, but preserves existing .zmd files.
@glpatcern glpatcern self-assigned this Oct 20, 2021
@glpatcern glpatcern requested a review from diocas October 20, 2021 11:29
Copy link
Contributor

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good in the PR.

But I'm not sure this is the best option conceptually... In the future, when we integrate the filepicker, do we plan to clean the DB and remove images (which are not stored anywhere else) or do we keep the images forever there? Either way is not great.

I know we cannot write to REVA to send the new file... But could we use the current prod backend and hack the opening from OCIS? Or we assume that the filepicker will arrive soon enough?

@glpatcern
Copy link
Member Author

(Did not have time to discuss live, let's keep the discussion here)

My assumption is we can get the file picker quite rapidly, but let me validate this with Javier and Michal in fact ;-)
Otherwise, you have a point in that we'd need to look after the pictures stored in the storage before dismantling it, which is not great. So if the above assumption is not true, I won't merge this now.

@glpatcern
Copy link
Member Author

In a second thought, I'll merge this and leave it disabled in the config. We will enable it in QA as appropriate.

@glpatcern glpatcern merged commit 141840c into master Oct 26, 2021
@glpatcern glpatcern deleted the disablezip branch October 26, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants