Show html path within wsl #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested again under a fresh install. Works fine in both WSL's Ubuntu terminal and the newish Windows terminal. Links should soon be clickable in Windows Terminal: microsoft/terminal#7699 @rongxin-liu mind taking another look at this PR? We have a lot of WSL users and it'd be nice to have this merged 😀 |
rongxin-liu
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #275
Checking if we're running wsl using https://www.scivision.dev/python-detect-wsl/
Then converting the path within Ubuntu to a windows path with
wslpath -w.Tested with
check50 cs50/problems/2021/fall/hello --localon macOS 12.2.1 with python 3.9.10 and WSL Ubuntu 20.04 with python 3.8.10WSL result:
To see the results in your browser go to file:///wsl.localhost/Ubuntu/tmp/tmpveuwk16x.htmlmacOS result:
To see the results in your browser go to file:///var/folders/j9/6b_9k8xs3pzcf8pxp6g08twh0000gn/T/tmp3iev6si6.html